Add prefix to PSR-4 autoloader #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PSR-4 autoloaders with no prefix can hurt performance, especially in large projects with many dependencies. When resolving class names to files, if Composer cannot use a prefix to limit the search paths, it has to search every autoloader with a blank prefix. This change adds a prefix to the autoloader, to avoid this problem. Running `composer diagnose` previously reported this: ~/src/php-sdk % composer diagnose Checking composer.json: WARNING Defining autoload.psr-4 with an empty namespace prefix is a bad idea for performance With this change, `composer diagnose` is happy. I couldn't add tests for this, because it's not a code change. But, I did run the test suite to verify that it everything still passes as expected.
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
Hi @dcloues , thank you for submitting this fix. I'd like to request you to fill out our CLA mentioned here: https://github.com/optimizely/php-sdk/blob/master/CONTRIBUTING.md#contributing-to-the-optimizely-php-sdk Once done, I shall be able to get this in. Thank you again. |
|
Hi @aliabbasrizvi - thanks so much! Sorry for missing the CLA the first time around - I read the contributing guide and somehow read right past it, even though it's super clear. I just submitted the agreement - thanks again. |
|
build |
1 similar comment
|
build |
|
Thanks @dcloues for sending this in. Changes look good. I am going to merge this in and it will hopefully be available in the next release 🙂. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PSR-4 autoloaders with no prefix can hurt performance, especially in large projects with many dependencies. When resolving class names to files, if Composer cannot use a prefix to limit the search paths, it has to search every autoloader with a blank prefix.
This change adds a prefix to the autoloader, to avoid this problem.
Running
composer diagnosepreviously reported this:With this change,
composer diagnoseis happy.I couldn't add tests for this, because it's not a code change. But, I did run the test suite to verify that it everything still passes as expected.